close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/go/types: use unqualified names for local objects in error messages 

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://golang.org/cl/77590043
This commit is contained in:
Robert Griesemer 2014-03-18 13:37:09 -07:00
parent 5893c271ff
commit 62216e60bb
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
go/types/errors.go
View File

@ -27,16 +27,19 @@ func (check *checker) sprintf(format string, args ...interface{}) string {
for i, arg := range args { for i, arg := range args {
switch a := arg.(type) { switch a := arg.(type) {
case nil: case nil:
args[i] = "<nil>" arg = "<nil>"
case operand: case operand:
panic("internal error: should always pass *operand") panic("internal error: should always pass *operand")
case token.Pos: case token.Pos:
args[i] = check.fset.Position(a).String() arg = check.fset.Position(a).String()
case ast.Expr: case ast.Expr:
args[i] = ExprString(a) arg = ExprString(a)
case Object:
arg = ObjectString(check.pkg, a)
case Type: case Type:
args[i] = TypeString(check.pkg, a) arg = TypeString(check.pkg, a)
} }
args[i] = arg
} }
return fmt.Sprintf(format, args...) return fmt.Sprintf(format, args...)
} }