From 6149f385e4c0773e6f83d3fb0300960403bcdff2 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Wed, 17 Apr 2019 16:21:47 -0400 Subject: [PATCH] internal/lsp: reply to shutdown request Fixes golang/go#31333 Change-Id: I5cb40baee49c4b1644df5612c977ab1d71942022 Reviewed-on: https://go-review.googlesource.com/c/tools/+/172639 Run-TryBot: Rebecca Stambler Reviewed-by: Ian Cottrell --- internal/lsp/protocol/server.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/internal/lsp/protocol/server.go b/internal/lsp/protocol/server.go index 4cb8e48b..3344b538 100644 --- a/internal/lsp/protocol/server.go +++ b/internal/lsp/protocol/server.go @@ -81,7 +81,9 @@ func serverHandler(log xlog.Logger, server Server) jsonrpc2.Handler { conn.Reply(ctx, r, nil, jsonrpc2.NewErrorf(jsonrpc2.CodeInvalidParams, "Expected no params")) return } - if err := server.Shutdown(ctx); err != nil { + if err := server.Shutdown(ctx); err == nil { + conn.Reply(ctx, r, nil, nil) + } else { log.Errorf(ctx, "%v", err) }