From 5e468032ea9e193c60de97cfcd040ffa7a9b774e Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Sun, 17 Apr 2016 12:37:22 -0400 Subject: [PATCH] cmd/guru: avoid bug when -scope="" strings.Split is not your friend. Change-Id: I829f08f113f3340b2dd865aea47f5759a427f7c4 Reviewed-on: https://go-review.googlesource.com/22116 Reviewed-by: Michael Matloob --- cmd/guru/main.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cmd/guru/main.go b/cmd/guru/main.go index 28ea2b39..8d55adf1 100644 --- a/cmd/guru/main.go +++ b/cmd/guru/main.go @@ -194,11 +194,17 @@ func main() { } } + // Avoid corner case of split(""). + var scope []string + if *scopeFlag != "" { + scope = strings.Split(*scopeFlag, ",") + } + // Ask the guru. query := Query{ Pos: posn, Build: ctxt, - Scope: strings.Split(*scopeFlag, ","), + Scope: scope, PTALog: ptalog, Reflection: *reflectFlag, Output: output,