From 5b59ce8b5f114a06fca053c08a380efbcbf7a5e5 Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Mon, 6 Jun 2016 04:27:18 -0700 Subject: [PATCH] cmd/bundle: More idiomatic flag.Usage. The responsibility of flag.Usage is to print usage to stderr: > Usage prints to standard error a usage message documenting all > defined command-line flags. Calling os.Exit(2) is outside of its scope, flag package does that. Change-Id: I3eef2b796e5ddedff6d5927dbcdbfff3a6082270 Reviewed-on: https://go-review.googlesource.com/23788 Reviewed-by: Joseph Holsten Reviewed-by: Alan Donovan --- cmd/bundle/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/bundle/main.go b/cmd/bundle/main.go index ac09ee89..7cd31c98 100644 --- a/cmd/bundle/main.go +++ b/cmd/bundle/main.go @@ -129,7 +129,6 @@ func addImportMap(s string) { func usage() { fmt.Fprintf(os.Stderr, "Usage: bundle [options] \n") flag.PrintDefaults() - os.Exit(2) } func main() { @@ -141,6 +140,7 @@ func main() { args := flag.Args() if len(args) != 1 { usage() + os.Exit(2) } if *dstPath != "" {