From 4e75c2682bad0876577742afbbe6115d32abf6a4 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Mon, 23 Feb 2015 14:24:45 -0500 Subject: [PATCH] cmd/oracle: check errors from Flush and Close. Change-Id: Ia3c61b37140a83769373b322de691362ac919a90 Reviewed-on: https://go-review.googlesource.com/5630 Reviewed-by: Robert Griesemer --- cmd/oracle/main.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/cmd/oracle/main.go b/cmd/oracle/main.go index 56bc72b4..ae980148 100644 --- a/cmd/oracle/main.go +++ b/cmd/oracle/main.go @@ -36,7 +36,6 @@ var ptalogFlag = flag.String("ptalog", "", var formatFlag = flag.String("format", "plain", "Output format. One of {plain,json,xml}.") -// TODO(adonovan): flip this flag after PTA presolver is implemented. var reflectFlag = flag.Bool("reflect", false, "Analyze reflection soundly (slow).") const useHelp = "Run 'oracle -help' for more information.\n" @@ -137,8 +136,12 @@ func main() { buf := bufio.NewWriter(f) ptalog = buf defer func() { - buf.Flush() - f.Close() + if err := buf.Flush(); err != nil { + log.Errorf("flush: %s", err) + } + if err := f.Close(); err != nil { + log.Errorf("close: %s", err) + } }() } }