From 4c772e4117aadef691f50702c97d5a914ee7a921 Mon Sep 17 00:00:00 2001 From: Robert Griesemer Date: Thu, 15 Mar 2018 17:47:48 -0700 Subject: [PATCH] [release-branch.go1.10] cmd/guru: fix .golden file (fix build) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This regression is due to https://go-review.googlesource.com/c/go/+/100235 which made the go/scanner behavior match the compiler's scanner by not modifying filenames in line directives in any form. Specifically, relative filenames now remain relative. This makes it easier to reason about the behavior of the scanner but may require clients to adjust those filenames. If removing the longer path in the .golden file is not satisfactory, the (scanner) client may have to massage positions returned via line directives; or better, the line directives are created with extended path information. R=​adonovan Change-Id: I836571a6dafef5e6d81e4c7add203c994e107055 Reviewed-on: https://go-review.googlesource.com/101015 Run-TryBot: Robert Griesemer Reviewed-by: Andrew Bonventre TryBot-Result: Gobot Gobot (cherry picked from commit c4b4e4b0fa4a67bbbfceacd5e484460d33fb87f5) Reviewed-on: https://go-review.googlesource.com/102798 Run-TryBot: Andrew Bonventre --- cmd/guru/testdata/src/referrers/main.golden | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/guru/testdata/src/referrers/main.golden b/cmd/guru/testdata/src/referrers/main.golden index 230e95e7..dc97f6ac 100644 --- a/cmd/guru/testdata/src/referrers/main.golden +++ b/cmd/guru/testdata/src/referrers/main.golden @@ -56,5 +56,5 @@ references to field f int -------- @referrers ref-type-U -------- references to type U int -open testdata/src/referrers/nosuchfile.y: no such file or directory (+ 1 more refs in this file) +open nosuchfile.y: no such file or directory (+ 1 more refs in this file)