From 48d14ded32f890900a3a87b10c3ebb253850e6d8 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Tue, 3 Sep 2013 15:41:05 -0400 Subject: [PATCH] go.tools/cmd/oracle: cosmetic tweaks to Emacs. 1. call display-buffer after the postprocessing step to avoid display glitch. 2. suppress the postprocessing progress message---it's too verbose. (instead I should just make the postprocessing loop faster) Also: rename channel-peers to just peers for consistency with other commands and documentation. R=dominik.honnef CC=golang-dev https://golang.org/cl/13388044 --- cmd/oracle/oracle.el | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/cmd/oracle/oracle.el b/cmd/oracle/oracle.el index 50e58303..c3718c40 100644 --- a/cmd/oracle/oracle.el +++ b/cmd/oracle/oracle.el @@ -106,10 +106,6 @@ result." (insert "\n") (compilation-mode) (setq compilation-error-screen-columns nil) - (let ((w (display-buffer (current-buffer)))) - (balance-windows) - (shrink-window-if-larger-than-buffer w) - (set-window-point w (point-min))) ;; Hide the file/line info to save space. ;; Replace each with a little widget. @@ -121,7 +117,7 @@ result." (while (not (null p)) (let ((np (compilation-next-single-property-change p 'compilation-message))) ;; TODO(adonovan): this can be verbose in the *Messages* buffer. - (message "Post-processing link (%d%%)" (/ (* p 100) (point-max))) + ;; (message "Post-processing link (%d%%)" (/ (* p 100) (point-max))) (if np (when (equal (line-number-at-pos p) (line-number-at-pos np)) ;; np is (typically) the space following ":"; consume it too. @@ -129,7 +125,12 @@ result." (goto-char np) (insert " "))) (setq p np))) - (message nil))))) + (message nil)) + + (let ((w (display-buffer (current-buffer)))) + (balance-windows) + (shrink-window-if-larger-than-buffer w) + (set-window-point w (point-min)))))) (defun go-oracle-callees () "Show possible callees of the function call at the current point." @@ -168,7 +169,7 @@ containing the current point." (interactive) (go-oracle--run "freevars")) -(defun go-oracle-channel-peers () +(defun go-oracle-peers () "Enumerate the set of possible corresponding sends/receives for this channel receive/send operation." (interactive)