From 3ff669b183a17dd5e5d03ed96e1715343cc21ff6 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Mon, 22 Apr 2019 12:49:04 -0400 Subject: [PATCH] internal/lsp: add check for nil package Fixes golang/go#31604 Change-Id: I60ec000d505c64783e5f51f62d168dc31c2fbe19 Reviewed-on: https://go-review.googlesource.com/c/tools/+/172968 Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot Reviewed-by: Ian Cottrell --- internal/lsp/source/identifier.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/lsp/source/identifier.go b/internal/lsp/source/identifier.go index ff75e056..a76b24b6 100644 --- a/internal/lsp/source/identifier.go +++ b/internal/lsp/source/identifier.go @@ -54,6 +54,9 @@ func Identifier(ctx context.Context, v View, f File, pos token.Pos) (*Identifier func identifier(ctx context.Context, v View, f File, pos token.Pos) (*IdentifierInfo, error) { fAST := f.GetAST(ctx) pkg := f.GetPackage(ctx) + if pkg == nil { + return nil, fmt.Errorf("no package for %s", f.URI()) + } if pkg.IsIllTyped() { return nil, fmt.Errorf("package for %s is ill typed", f.URI()) }