From 3096223ce80706f73be7154726e67f3539691be7 Mon Sep 17 00:00:00 2001 From: Benny Siegert Date: Wed, 20 Mar 2019 15:12:34 +0100 Subject: [PATCH] internal/lsp/cmd: fix regexp in test The test fails if the GOROOT directory contains a dash, e.g. as in /usr/lib/google-golang on corporate workstations, or on certain builders. Change-Id: If08c438764f4b76fff7fb43ccf3e4fd56afeff1a Reviewed-on: https://go-review.googlesource.com/c/tools/+/168063 Reviewed-by: Ian Cottrell Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- internal/lsp/cmd/definition_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/lsp/cmd/definition_test.go b/internal/lsp/cmd/definition_test.go index 7508c0ce..c19957f1 100644 --- a/internal/lsp/cmd/definition_test.go +++ b/internal/lsp/cmd/definition_test.go @@ -38,7 +38,7 @@ func TestDefinitionHelpExample(t *testing.T) { } thisFile := filepath.Join(dir, "definition.go") baseArgs := []string{"query", "definition"} - expect := regexp.MustCompile(`^[\w/\\:_]+flag[/\\]flag.go:\d+:\d+-\d+: defined here as type flag.FlagSet struct{.*}$`) + expect := regexp.MustCompile(`^[\w/\\:_-]+flag[/\\]flag.go:\d+:\d+-\d+: defined here as type flag.FlagSet struct{.*}$`) for _, query := range []string{ fmt.Sprintf("%v:%v:%v", thisFile, cmd.ExampleLine, cmd.ExampleColumn), fmt.Sprintf("%v:#%v", thisFile, cmd.ExampleOffset)} {