go/...: use recommended issue tracker URLs

Change-Id: I249de6aad723f4c2c49dc028995f4f6d1fcc54fd
Reviewed-on: https://go-review.googlesource.com/c/152598
Run-TryBot: Alan Donovan <adonovan@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Alan Donovan 2018-12-04 17:08:00 -05:00
parent 555fafe5a2
commit 22934f0fdb
17 changed files with 24 additions and 22 deletions

View File

@ -514,7 +514,7 @@ func asmParseDecl(pass *analysis.Pass, decl *ast.FuncDecl) map[string]*asmFunc {
for _, fld := range list { for _, fld := range list {
t := pass.TypesInfo.Types[fld.Type].Type t := pass.TypesInfo.Types[fld.Type].Type
// Work around github.com/golang/go/issues/28277. // Work around https://golang.org/issue/28277.
if t == nil { if t == nil {
if ell, ok := fld.Type.(*ast.Ellipsis); ok { if ell, ok := fld.Type.(*ast.Ellipsis); ok {
t = types.NewSlice(pass.TypesInfo.Types[ell.Elt].Type) t = types.NewSlice(pass.TypesInfo.Types[ell.Elt].Type)

View File

@ -45,7 +45,7 @@ func run(pass *analysis.Pass) (interface{}, error) {
// TODO(adonovan): this reports n(n-1)/2 errors for an // TODO(adonovan): this reports n(n-1)/2 errors for an
// expression e||...||e of depth n. Fix. // expression e||...||e of depth n. Fix.
// See https://github.com/golang/go/issues/28086. // See https://golang.org/issue/28086.
comm := op.commutativeSets(pass.TypesInfo, e) comm := op.commutativeSets(pass.TypesInfo, e)
for _, exprs := range comm { for _, exprs := range comm {
op.checkRedundant(pass, exprs) op.checkRedundant(pass, exprs)

View File

@ -48,7 +48,7 @@ func RatherStupidConditions() {
// The various r.* patterns are intended to match duplicate // The various r.* patterns are intended to match duplicate
// diagnostics reported for the same underlying problem. // diagnostics reported for the same underlying problem.
// See github.com/golang/go/issues/28086. // See https://golang.org/issue/28086.
// TODO(adonovan): fix the checker. // TODO(adonovan): fix the checker.
_ = i == 1 || i == 1 || f() == 1 // want `redundant or: i == 1 \|\| i == 1` `r.*` _ = i == 1 || i == 1 || f() == 1 // want `redundant or: i == 1 \|\| i == 1` `r.*`

View File

@ -182,7 +182,7 @@ func readConfig(filename string) (*Config, error) {
} }
var importerForCompiler = func(_ *token.FileSet, compiler string, lookup importer.Lookup) types.Importer { var importerForCompiler = func(_ *token.FileSet, compiler string, lookup importer.Lookup) types.Importer {
// broken legacy implementation (github.com/golang/go/issues/28995) // broken legacy implementation (https://golang.org/issue/28995)
return importer.For(compiler, lookup) return importer.For(compiler, lookup)
} }

View File

@ -1,6 +1,6 @@
package main package main
// Regression test for https://github.com/golang/go/issues/23925 // Regression test for https://golang.org/issue/23925
type stringFlagImpl string type stringFlagImpl string

View File

@ -16,7 +16,7 @@
// time before the Go 1.8 release and rebuild and redeploy their // time before the Go 1.8 release and rebuild and redeploy their
// developer tools, which will then be able to consume both Go 1.7 and // developer tools, which will then be able to consume both Go 1.7 and
// Go 1.8 export data files, so they will work before and after the // Go 1.8 export data files, so they will work before and after the
// Go update. (See discussion at https://github.com/golang/go/issues/15651.) // Go update. (See discussion at https://golang.org/issue/15651.)
// //
package gcexportdata // import "golang.org/x/tools/go/gcexportdata" package gcexportdata // import "golang.org/x/tools/go/gcexportdata"

View File

@ -780,7 +780,7 @@ func (imp *importer) doImport(from *PackageInfo, to string) (*types.Package, err
if to == "C" { if to == "C" {
// This should be unreachable, but ad hoc packages are // This should be unreachable, but ad hoc packages are
// not currently subject to cgo preprocessing. // not currently subject to cgo preprocessing.
// See https://github.com/golang/go/issues/11627. // See https://golang.org/issue/11627.
return nil, fmt.Errorf(`the loader doesn't cgo-process ad hoc packages like %q; see Go issue 11627`, return nil, fmt.Errorf(`the loader doesn't cgo-process ad hoc packages like %q; see Go issue 11627`,
from.Pkg.Path()) from.Pkg.Path())
} }

View File

@ -31,7 +31,7 @@ func TestStdlib(t *testing.T) {
t.Skipf("incomplete std lib on %s", runtime.GOOS) t.Skipf("incomplete std lib on %s", runtime.GOOS)
} }
if testing.Short() { if testing.Short() {
t.Skip("skipping in short mode; uses tons of memory (golang.org/issue/14113)") t.Skip("skipping in short mode; uses tons of memory (https://golang.org/issue/14113)")
} }
runtime.GC() runtime.GC()
@ -120,7 +120,7 @@ func TestStdlib(t *testing.T) {
func TestCgoOption(t *testing.T) { func TestCgoOption(t *testing.T) {
if testing.Short() { if testing.Short() {
t.Skip("skipping in short mode; uses tons of memory (golang.org/issue/14113)") t.Skip("skipping in short mode; uses tons of memory (https://golang.org/issue/14113)")
} }
switch runtime.GOOS { switch runtime.GOOS {
// On these systems, the net and os/user packages don't use cgo // On these systems, the net and os/user packages don't use cgo

View File

@ -580,7 +580,7 @@ func golistDriverCurrent(cfg *Config, words ...string) (*driverResponse, error)
OtherFiles: absJoin(p.Dir, otherFiles(p)...), OtherFiles: absJoin(p.Dir, otherFiles(p)...),
} }
// Workaround for github.com/golang/go/issues/28749. // Workaround for https://golang.org/issue/28749.
// TODO(adonovan): delete before go1.12 release. // TODO(adonovan): delete before go1.12 release.
out := pkg.CompiledGoFiles[:0] out := pkg.CompiledGoFiles[:0]
for _, f := range pkg.CompiledGoFiles { for _, f := range pkg.CompiledGoFiles {
@ -726,7 +726,7 @@ func invokeGo(cfg *Config, args ...string) (*bytes.Buffer, error) {
// As of writing, go list -export prints some non-fatal compilation // As of writing, go list -export prints some non-fatal compilation
// errors to stderr, even with -e set. We would prefer that it put // errors to stderr, even with -e set. We would prefer that it put
// them in the Package.Error JSON (see http://golang.org/issue/26319). // them in the Package.Error JSON (see https://golang.org/issue/26319).
// In the meantime, there's nowhere good to put them, but they can // In the meantime, there's nowhere good to put them, but they can
// be useful for debugging. Print them if $GOPACKAGESPRINTGOLISTERRORS // be useful for debugging. Print them if $GOPACKAGESPRINTGOLISTERRORS
// is set. // is set.

View File

@ -872,7 +872,8 @@ func TestLoadAllSyntaxImportErrors(t *testing.T) {
packagestest.TestAll(t, testLoadAllSyntaxImportErrors) packagestest.TestAll(t, testLoadAllSyntaxImportErrors)
} }
func testLoadAllSyntaxImportErrors(t *testing.T, exporter packagestest.Exporter) { func testLoadAllSyntaxImportErrors(t *testing.T, exporter packagestest.Exporter) {
// TODO(matloob): Remove this once go list -e -compiled is fixed. See golang.org/issue/26755 // TODO(matloob): Remove this once go list -e -compiled is fixed.
// See https://golang.org/issue/26755
t.Skip("go list -compiled -e fails with non-zero exit status for empty packages") t.Skip("go list -compiled -e fails with non-zero exit status for empty packages")
exported := packagestest.Export(t, exporter, []packagestest.Module{{ exported := packagestest.Export(t, exporter, []packagestest.Module{{

View File

@ -7,10 +7,11 @@
package packages_test package packages_test
import ( import (
"golang.org/x/tools/go/packages"
"runtime" "runtime"
"strings" "strings"
"testing" "testing"
"golang.org/x/tools/go/packages"
) )
func TestLoadImportsC(t *testing.T) { func TestLoadImportsC(t *testing.T) {
@ -24,7 +25,7 @@ func TestLoadImportsC(t *testing.T) {
t.Skipf("skipping on windows; packages on windows do not satisfy conditions for test.") t.Skipf("skipping on windows; packages on windows do not satisfy conditions for test.")
} }
if runtime.GOOS == "plan9" { if runtime.GOOS == "plan9" {
// See https://github.com/golang/go/issues/27100. // See https://golang.org/issue/27100.
t.Skip(`skipping on plan9; for some reason "net [syscall.test]" is not loaded`) t.Skip(`skipping on plan9; for some reason "net [syscall.test]" is not loaded`)
} }

View File

@ -59,7 +59,7 @@ func TestStdlibMetadata(t *testing.T) {
func TestCgoOption(t *testing.T) { func TestCgoOption(t *testing.T) {
if testing.Short() { if testing.Short() {
t.Skip("skipping in short mode; uses tons of memory (golang.org/issue/14113)") t.Skip("skipping in short mode; uses tons of memory (https://golang.org/issue/14113)")
} }
// TODO(adonovan): see if we can get away without these old // TODO(adonovan): see if we can get away without these old

View File

@ -543,7 +543,7 @@ func checkWarningExpectation(prog *ssa.Program, e *expectation, warnings []point
func TestInput(t *testing.T) { func TestInput(t *testing.T) {
if testing.Short() { if testing.Short() {
t.Skip("skipping in short mode; this test requires tons of memory; golang.org/issue/14113") t.Skip("skipping in short mode; this test requires tons of memory; https://golang.org/issue/14113")
} }
ok := true ok := true

View File

@ -156,9 +156,9 @@ var testdataTests = []string{
type successPredicate func(exitcode int, output string) error type successPredicate func(exitcode int, output string) error
func run(t *testing.T, dir, input string, success successPredicate) bool { func run(t *testing.T, dir, input string, success successPredicate) bool {
t.Skip("golang.org/issue/27292") t.Skip("https://golang.org/issue/27292")
if runtime.GOOS == "darwin" { if runtime.GOOS == "darwin" {
t.Skip("skipping on darwin until golang.org/issue/23166 is fixed") t.Skip("skipping on darwin until https://golang.org/issue/23166 is fixed")
} }
fmt.Printf("Input: %s\n", input) fmt.Printf("Input: %s\n", input)

View File

@ -82,7 +82,7 @@ func init() {
} }
} }
// Regression test for https://github.com/golang/go/issues/10127: // Regression test for https://golang.org/issue/10127:
// composite literal clobbers destination before reading from it. // composite literal clobbers destination before reading from it.
func init() { func init() {
// map // map
@ -166,7 +166,7 @@ func init() {
} }
} }
// Regression test for https://github.com/golang/go/issues/13341: // Regression test for https://golang.org/issue/13341:
// within a map literal, if a key expression is a composite literal, // within a map literal, if a key expression is a composite literal,
// Go 1.5 allows its type to be omitted. An & operation may be implied. // Go 1.5 allows its type to be omitted. An & operation may be implied.
func init() { func init() {

View File

@ -48,7 +48,7 @@ func bytesAllocated() uint64 {
func TestStdlib(t *testing.T) { func TestStdlib(t *testing.T) {
if testing.Short() { if testing.Short() {
t.Skip("skipping in short mode; too slow (golang.org/issue/14113)") t.Skip("skipping in short mode; too slow (https://golang.org/issue/14113)")
} }
// Load, parse and type-check the program. // Load, parse and type-check the program.
t0 := time.Now() t0 := time.Now()

View File

@ -10,7 +10,7 @@
// modified to make the identifiers exported. It's provided here // modified to make the identifiers exported. It's provided here
// for developers who want to write tools with similar semantics. // for developers who want to write tools with similar semantics.
// It needs to be manually kept in sync with upstream when changes are // It needs to be manually kept in sync with upstream when changes are
// made to cmd/go/internal/get; see https://golang.org/issues/11490. // made to cmd/go/internal/get; see https://golang.org/issue/11490.
// //
package vcs // import "golang.org/x/tools/go/vcs" package vcs // import "golang.org/x/tools/go/vcs"