diff --git a/go/analysis/analysistest/analysistest.go b/go/analysis/analysistest/analysistest.go index 312dfd5b..b5c53c07 100644 --- a/go/analysis/analysistest/analysistest.go +++ b/go/analysis/analysistest/analysistest.go @@ -128,7 +128,7 @@ func loadPackage(dir, pkgpath string) (*packages.Package, error) { Mode: packages.LoadAllSyntax, Dir: dir, Tests: true, - Env: append(os.Environ(), "GOPATH="+dir), + Env: append(os.Environ(), "GOPATH="+dir, "GO111MODULE=off", "GOPROXY=off"), } pkgs, err := packages.Load(cfg, pkgpath) if err != nil { diff --git a/go/analysis/passes/findcall/findcall_test.go b/go/analysis/passes/findcall/findcall_test.go index 105f1a0e..c521885c 100644 --- a/go/analysis/passes/findcall/findcall_test.go +++ b/go/analysis/passes/findcall/findcall_test.go @@ -1,26 +1,12 @@ package findcall_test import ( - "log" - "os" "testing" "golang.org/x/tools/go/analysis/analysistest" "golang.org/x/tools/go/analysis/passes/findcall" ) -func init() { - // This test currently requires GOPATH mode. - // Explicitly disabling module mode should suffix, but - // we'll also turn off GOPROXY just for good measure. - if err := os.Setenv("GO111MODULE", "off"); err != nil { - log.Fatal(err) - } - if err := os.Setenv("GOPROXY", "off"); err != nil { - log.Fatal(err) - } -} - // TestFromStringLiterals demonstrates how to test an analysis using // a table of string literals for each test case. // diff --git a/go/analysis/passes/pkgfact/pkgfact_test.go b/go/analysis/passes/pkgfact/pkgfact_test.go index 511026c0..11e6f893 100644 --- a/go/analysis/passes/pkgfact/pkgfact_test.go +++ b/go/analysis/passes/pkgfact/pkgfact_test.go @@ -1,26 +1,12 @@ package pkgfact_test import ( - "log" - "os" "testing" "golang.org/x/tools/go/analysis/analysistest" "golang.org/x/tools/go/analysis/passes/pkgfact" ) -func init() { - // This test currently requires GOPATH mode. - // Explicitly disabling module mode should suffix, but - // we'll also turn off GOPROXY just for good measure. - if err := os.Setenv("GO111MODULE", "off"); err != nil { - log.Fatal(err) - } - if err := os.Setenv("GOPROXY", "off"); err != nil { - log.Fatal(err) - } -} - func Test(t *testing.T) { testdata := analysistest.TestData() analysistest.Run(t, testdata, pkgfact.Analyzer,