close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

go.tools/container/intsets: use " " not ", " as (*Sparse).String() separator. 

This is both easier to read and 25% shorter (helpful when
using String() as a map key for interning sets).

LGTM=gri
R=gri
CC=golang-codereviews
https://golang.org/cl/96370045
This commit is contained in:
Alan Donovan 2014-05-16 13:06:08 -04:00
parent 18c694293a
commit 174d6e8ca3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
container/intsets/sparse.go
View File

@ -690,7 +690,7 @@ func (s *Sparse) String() string {
buf.WriteByte('{') buf.WriteByte('{')
s.forEach(func(x int) { s.forEach(func(x int) {
if buf.Len() > 1 { if buf.Len() > 1 {
buf.WriteString(", ") buf.WriteByte(' ')
} }
fmt.Fprintf(&buf, "%d", x) fmt.Fprintf(&buf, "%d", x)
}) })

4
container/intsets/sparse_test.go
View File

@ -43,8 +43,8 @@ func TestBasics(t *testing.T) {
if !s.Insert(435) { if !s.Insert(435) {
t.Errorf("Insert(435): got false, want true") t.Errorf("Insert(435): got false, want true")
} }
if s := s.String(); s != "{3, 435}" { if s := s.String(); s != "{3 435}" {
t.Errorf("String({3, 435}): got %q, want \"{3, 435}\"", s) t.Errorf("String({3 435}): got %q, want \"{3 435}\"", s)
} }
if max := s.Max(); max != 435 { if max := s.Max(); max != 435 {
t.Errorf("Max: got %d, want 435", max) t.Errorf("Max: got %d, want 435", max)