From 129869a1a69588204419117f686297977a7af178 Mon Sep 17 00:00:00 2001 From: Chris Manghane Date: Wed, 23 Jul 2014 10:22:29 -0700 Subject: [PATCH] go.tools/dashboard: don't do method calls or field lookups on a possibly nil repo LGTM=mischief, adg R=adg, mischief CC=golang-codereviews https://golang.org/cl/106660043 --- dashboard/builder/main.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dashboard/builder/main.go b/dashboard/builder/main.go index d3daddec..e10e327c 100644 --- a/dashboard/builder/main.go +++ b/dashboard/builder/main.go @@ -623,12 +623,14 @@ func commitPoll(repo *Repo, pkg, key string) { repo, err = RemoteRepo(pkg, pkgPath) if err != nil { log.Printf("Error cloning package (%s): %s", pkg, err) + return } - repo, err = repo.Clone(repo.Path, "tip") + path := repo.Path + repo, err = repo.Clone(path, "tip") if err != nil { log.Printf("%s: hg clone failed: %v", pkg, err) - if err := os.RemoveAll(repo.Path); err != nil { + if err := os.RemoveAll(path); err != nil { log.Printf("%s: %v", pkg, err) } }