close_issue_1
/
tools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dashboard: fix typo 

LGTM=bradfitz
R=adg, bradfitz
CC=golang-codereviews
https://golang.org/cl/162180043
This commit is contained in:
Dmitriy Vyukov 2014-10-27 13:07:31 +03:00
parent 0d5881e51c
commit 0b5a61fa3a
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dashboard/app/build/handler.go
View File

@ -455,7 +455,7 @@ func buildPerfTodo(c appengine.Context, builder string) (*PerfTodo, error) {
nums = append(nums, num) nums = append(nums, num)
} }
} }
todo.CommitNums = orderPrefTodo(nums) todo.CommitNums = orderPerfTodo(nums)
todo.CommitNums = append(todo.CommitNums, releaseNums...) todo.CommitNums = append(todo.CommitNums, releaseNums...)
if _, err = datastore.Put(c, todo.Key(c), todo); err != nil { if _, err = datastore.Put(c, todo.Key(c), todo); err != nil {
return fmt.Errorf("putting PerfTodo: %v", err) return fmt.Errorf("putting PerfTodo: %v", err)

4
dashboard/app/build/perf.go
View File

@ -246,14 +246,14 @@ func significantPerfChanges(pc *PerfConfig, builder string, prevRes, res *PerfRe
return changes return changes
} }
// orderPrefTodo reorders commit nums for benchmarking todo. // orderPerfTodo reorders commit nums for benchmarking todo.
// The resulting order is somewhat tricky. We want 2 things: // The resulting order is somewhat tricky. We want 2 things:
// 1. benchmark sequentially backwards (this provides information about most // 1. benchmark sequentially backwards (this provides information about most
// recent changes, and allows to estimate noise levels) // recent changes, and allows to estimate noise levels)
// 2. benchmark old commits in "scatter" order (this allows to quickly gather // 2. benchmark old commits in "scatter" order (this allows to quickly gather
// brief information about thousands of old commits) // brief information about thousands of old commits)
// So this function interleaves the two orders. // So this function interleaves the two orders.
func orderPrefTodo(nums []int) []int { func orderPerfTodo(nums []int) []int {
sort.Ints(nums) sort.Ints(nums)
n := len(nums) n := len(nums)
pow2 := uint32(0) // next power-of-two that is >= n pow2 := uint32(0) // next power-of-two that is >= n