From 08bd53a4b4c43fb1e199ef0baf706273b2e25fd0 Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Tue, 28 May 2019 15:17:07 -0400 Subject: [PATCH] internal/lsp: run analyses despite some errors Updates golang/go#32247 Change-Id: Id474e62ea70676c782eb49dddebd64d7f274d2cf Reviewed-on: https://go-review.googlesource.com/c/tools/+/179218 Run-TryBot: Rebecca Stambler Reviewed-by: Ian Cottrell --- internal/lsp/source/analysis.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/lsp/source/analysis.go b/internal/lsp/source/analysis.go index 46e64b41..b1e777f5 100644 --- a/internal/lsp/source/analysis.go +++ b/internal/lsp/source/analysis.go @@ -158,7 +158,7 @@ func (act *Action) execOnce(ctx context.Context, fset *token.FileSet) error { } act.pass = pass - if len(act.Pkg.GetErrors()) > 0 && !pass.Analyzer.RunDespiteErrors { + if act.Pkg.IsIllTyped() && !pass.Analyzer.RunDespiteErrors { act.err = fmt.Errorf("analysis skipped due to errors in package: %v", act.Pkg.GetErrors()) } else { act.result, act.err = pass.Analyzer.Run(pass)