fix: 修复 count.Shadow 函数死锁问题
This commit is contained in:
parent
1005d7458d
commit
34ca7f07d2
|
@ -1,6 +1,7 @@
|
||||||
package counter
|
package counter
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"fmt"
|
||||||
"github.com/kercylan98/minotaur/utils/generic"
|
"github.com/kercylan98/minotaur/utils/generic"
|
||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
@ -30,15 +31,47 @@ type Counter[K comparable, V generic.Number] struct {
|
||||||
lock sync.RWMutex
|
lock sync.RWMutex
|
||||||
sub bool
|
sub bool
|
||||||
dr map[K]int64
|
dr map[K]int64
|
||||||
|
drm map[string]int64
|
||||||
c map[K]any
|
c map[K]any
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// AddWithMark 添加计数,根据 mark 判断是否重复计数
|
||||||
|
func (slf *Counter[K, V]) AddWithMark(mark, key K, value V, expired time.Duration) {
|
||||||
|
slf.lock.Lock()
|
||||||
|
if expired > 0 {
|
||||||
|
now := time.Now().Unix()
|
||||||
|
mk := fmt.Sprintf("%v_%v", mark, key)
|
||||||
|
expiredTime, exist := slf.drm[mk]
|
||||||
|
if exist {
|
||||||
|
if expiredTime > now {
|
||||||
|
slf.lock.Unlock()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
}
|
||||||
|
slf.drm[mk] = now + int64(expired/time.Second)
|
||||||
|
}
|
||||||
|
|
||||||
|
v, exist := slf.c[key]
|
||||||
|
if !exist {
|
||||||
|
slf.c[key] = value
|
||||||
|
slf.lock.Unlock()
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if v, ok := v.(V); !ok {
|
||||||
|
slf.lock.Unlock()
|
||||||
|
panic("counter value is sub counter")
|
||||||
|
} else {
|
||||||
|
slf.c[key] = v + value
|
||||||
|
}
|
||||||
|
slf.lock.Unlock()
|
||||||
|
}
|
||||||
|
|
||||||
// Add 添加计数
|
// Add 添加计数
|
||||||
// - 当设置了 expired 时,在 expired 时间内,不会重复计数
|
// - 当设置了 expired 时,在 expired 时间内,不会重复计数
|
||||||
// - 需要注意的是,当第一次设置了 expired,第二次未设置时,第二次的计数将生效
|
// - 需要注意的是,当第一次设置了 expired,第二次未设置时,第二次的计数将生效
|
||||||
func (slf *Counter[K, V]) Add(key K, value V, expired ...time.Duration) {
|
func (slf *Counter[K, V]) Add(key K, value V, expired ...time.Duration) {
|
||||||
slf.lock.Lock()
|
slf.lock.Lock()
|
||||||
if len(expired) > 0 {
|
if len(expired) > 0 && expired[0] > 0 {
|
||||||
now := time.Now().Unix()
|
now := time.Now().Unix()
|
||||||
expiredTime, exist := slf.dr[key]
|
expiredTime, exist := slf.dr[key]
|
||||||
if exist {
|
if exist {
|
||||||
|
|
|
@ -6,16 +6,18 @@ import (
|
||||||
)
|
)
|
||||||
|
|
||||||
func newShadow[K comparable, V generic.Number](counter *Counter[K, V]) *Shadow[K, V] {
|
func newShadow[K comparable, V generic.Number](counter *Counter[K, V]) *Shadow[K, V] {
|
||||||
counter.lock.Lock()
|
counter.lock.RLock()
|
||||||
shadow := &Shadow[K, V]{
|
shadow := &Shadow[K, V]{
|
||||||
Sub: counter.sub,
|
Sub: counter.sub,
|
||||||
DeduplicationRecord: hash.Copy(counter.dr),
|
DeduplicationRecord: hash.Copy(counter.dr),
|
||||||
Counter: counter.GetCounts(),
|
DeduplicationRecordMark: hash.Copy(counter.drm),
|
||||||
}
|
}
|
||||||
for k, c := range counter.GetSubCounters() {
|
counter.lock.RUnlock()
|
||||||
|
shadow.Counter = counter.GetCounts()
|
||||||
|
subs := counter.GetSubCounters()
|
||||||
|
for k, c := range subs {
|
||||||
shadow.SubCounters[k] = newShadow(c)
|
shadow.SubCounters[k] = newShadow(c)
|
||||||
}
|
}
|
||||||
counter.lock.Unlock()
|
|
||||||
return shadow
|
return shadow
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -23,6 +25,7 @@ func newShadow[K comparable, V generic.Number](counter *Counter[K, V]) *Shadow[K
|
||||||
type Shadow[K comparable, V generic.Number] struct {
|
type Shadow[K comparable, V generic.Number] struct {
|
||||||
Sub bool // 是否为子计数器
|
Sub bool // 是否为子计数器
|
||||||
DeduplicationRecord map[K]int64 // 最后一次写入时间
|
DeduplicationRecord map[K]int64 // 最后一次写入时间
|
||||||
|
DeduplicationRecordMark map[string]int64 // 最后一次写入时间
|
||||||
Counter map[K]V // 计数器
|
Counter map[K]V // 计数器
|
||||||
SubCounters map[K]*Shadow[K, V] // 子计数器
|
SubCounters map[K]*Shadow[K, V] // 子计数器
|
||||||
}
|
}
|
||||||
|
@ -42,6 +45,7 @@ func (slf *Shadow[K, V]) toCounter(parent *Counter[K, V]) *Counter[K, V] {
|
||||||
counter.dr = parent.dr
|
counter.dr = parent.dr
|
||||||
} else {
|
} else {
|
||||||
counter.dr = hash.Copy(slf.DeduplicationRecord)
|
counter.dr = hash.Copy(slf.DeduplicationRecord)
|
||||||
|
counter.drm = hash.Copy(slf.DeduplicationRecordMark)
|
||||||
}
|
}
|
||||||
for k, v := range slf.Counter {
|
for k, v := range slf.Counter {
|
||||||
counter.c[k] = v
|
counter.c[k] = v
|
||||||
|
|
Loading…
Reference in New Issue